Skip to content

[ONB-4398] [Compose] Add crossborder transfer cancel/simulate_credit and evm_address beneficiaries - #55

Merged
fin-compose[bot] merged 1 commit into
mainfrom
compose/crossborder-cancel-evm-8fc2
Nov 16, 2026
Merged

fin-compose[bot] merged 1 commit into
mainfrom
compose/crossborder-cancel-evm-8fc2

Conversation

@FranciscaOtero

Copy link
Copy Markdown
Contributor

Contexto

The public API (fintoc-rails 7504033b..main, 2026-11-09 to today) added crossborder transfer actions and USDT wallet beneficiaries that the SDK didn't support yet. Creating an evm_address beneficiary was impossible because the SDK required US bank fields. This PR closes those gaps.

¿Qué hay de nuevo?

  • client.v2.crossborder.transfers.cancel(id) and simulate_credit(id) (test mode only) — fintoc-com/fintoc-rails#20605
  • client.v2.crossborder.beneficiaries.create only requires holder_type and account_identifier, so evm_address wallets (account_scheme, network) work; routing_number, bank_name and address are still forwarded when given — fintoc-com/fintoc-rails#20943
  • CrossborderBeneficiary exposes account_scheme, currency, network and account_identifier; to_s shows the wallet for evm_address
  • CrossborderQuote exposes kind (locked / indicative)
  • New error classes: TransferNotCancellableError, CreditAlreadySimulatedError, CreditSimulationUnavailableError, UsdtCollectionAlreadyOpenError, PaymentMethodCanceledError (fintoc-com/fintoc-rails#20993)
  • README examples for wallet beneficiaries, cancel and simulate credit

Tests

  • Unit tests with WebMock and synthetic fixtures built from the spec (no cassettes added)
  • Error code resolution tests

Release notes

  • Added client.v2.crossborder.transfers.cancel and client.v2.crossborder.transfers.simulate_credit (test mode only).
  • client.v2.crossborder.beneficiaries.create no longer requires routing_number, bank_name and address, so it can create evm_address (USDT wallet) beneficiaries.
  • Added account_scheme, currency, network and account_identifier to CrossborderBeneficiary, and kind to CrossborderQuote.
  • Added error classes TransferNotCancellableError, CreditAlreadySimulatedError, CreditSimulationUnavailableError, UsdtCollectionAlreadyOpenError and PaymentMethodCanceledError.

Safety Checks

  • Versión y CHANGELOG actualizados (si corresponde)

Consideraciones

Left out, already aligned (released in earlier versions, or the SDK forwards params and keeps nested hashes and string enums as-is):

  • Crossborder beneficiaries/quotes/transfers CRUD and fintoc_fee (fintoc-com/fintoc-rails#20605, fintoc-com/fintoc-rails#20911, fintoc-com/fintoc-rails#20906), account certificates (fintoc-com/fintoc-rails#20588) and checkout_sessions.confirm (fintoc-com/fintoc-rails#20935)
  • payment_method_options.card.bins (fintoc-com/fintoc-rails#20751), ui_mode: fields and session_token for payment and setup flows (fintoc-com/fintoc-rails#20837, fintoc-com/fintoc-rails#21037)
  • split.inherited on invoices (fintoc-com/fintoc-rails#20601) and the invoice.split_redirected event type (fintoc-com/fintoc-rails#20443)
  • Onboarding cmf_regulated, cmf_registration_number and cmf_application_proof (fintoc-com/fintoc-rails#20814)
  • setup_intent error reasons and payment_method_inactive (fintoc-com/fintoc-rails#20978): PaymentMethodInactiveError already exists
  • Webhook endpoints limit_exceeded (fintoc-com/fintoc-rails#20758), invalid_url (fintoc-com/fintoc-rails#20998) and test retry docs (fintoc-com/fintoc-rails#20836, fintoc-com/fintoc-rails#20874): error classes already exist

Rollback

Revert the PR. It only adds public surface and relaxes required arguments.

🤖🐙 Created with Compose · View session

…iciaries

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
@FranciscaOtero FranciscaOtero added the agent:compose PR created by Compose AI agent label Nov 16, 2026
@FranciscaOtero FranciscaOtero self-assigned this Nov 16, 2026
@fin-hermes fin-hermes Bot added the size/L label Nov 16, 2026
@FranciscaOtero FranciscaOtero added the release:minor Publica una versión minor al mergear label Nov 16, 2026
@fin-hermes fin-hermes Bot added the risk:low label Nov 16, 2026
@FranciscaOtero

Copy link
Copy Markdown
Contributor Author

fin review

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FranciscaOtero
FranciscaOtero marked this pull request as ready for review November 16, 2026 12:07

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@fin-compose
fin-compose Bot merged commit 1da8954 into main Nov 16, 2026
9 checks passed
@fin-compose
fin-compose Bot deleted the compose/crossborder-cancel-evm-8fc2 branch November 16, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:compose PR created by Compose AI agent release:minor Publica una versión minor al mergear risk:low size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant